EPMRPP-107835 || Add hasNestedSteps flag#22
Conversation
WalkthroughAdded a primitive boolean property Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
src/main/java/com/epam/ta/reportportal/ws/reporting/TestItemResource.java (2)
27-29: Nit: keep import order consistent with project styleReordering imports is a no-op; just ensure it matches the repo’s Checkstyle/Spotless rules to avoid CI noise. If the project groups imports (java., javax., third‑party, project, lombok), please align accordingly.
119-121: New flag hasNestedSteps: confirm serialization/defaults and population path
- With
@JsonInclude(Include.NON_NULL)and a primitiveboolean,hasNestedStepswill always serialize (false included). This mirrorshasChildren/hasStats; confirm that’s desired for clients.- Verify the service layer/populators actually set this flag; otherwise clients may always see
falseeven when nested steps exist.- TestItemResourceOld extends this class, so the flag will also appear in the “old” representation. Confirm that exposing it there is intentional.
- If you want to omit when unknown, consider
Boolean(nullable) or@JsonInclude(Include.NON_DEFAULT). If consistency with existing booleans is the priority, current choice is fine.- Minor: for readability, consider placing this field near
hasChildren/hasStats.I can add a couple of JSON (de)serialization tests to lock the contract if helpful.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/main/java/com/epam/ta/reportportal/ws/reporting/TestItemResource.java(2 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
src/main/java/com/epam/ta/reportportal/ws/reporting/TestItemResource.java (1)
src/main/java/com/epam/ta/reportportal/ws/reporting/TestItemResourceOld.java (1)
Getter(35-50)
2 participants
Summary by CodeRabbit
New Features
Style